Skip to content

Updating dynamic data masking to use the RuleState property#1116

Merged
stankovski merged 8 commits intoAzure:devfrom
yoavrubin:dev
Oct 19, 2015
Merged

Updating dynamic data masking to use the RuleState property#1116
stankovski merged 8 commits intoAzure:devfrom
yoavrubin:dev

Conversation

@yoavrubin
Copy link
Member

@yoavrubin yoavrubin commented Oct 14, 2015

No description provided.

@azurecla
Copy link

azurecla commented Oct 14, 2015

Hi @yoavrubin, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (yrubin). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@yoavrubin
Copy link
Member Author

yoavrubin commented Oct 15, 2015

Can be merged

stankovski
stankovski reviewed Oct 19, 2015
View reviewed changes
src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/DataMaskingTests.cs Outdated
Copy link
Member

@stankovski stankovski Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were disabled because they were taking over 5 sec per tests. Based on the last test run they still take 760 seconds all together (and about 100 sec each). Please either fix the performance or exclude them from the CI test run. If you mark them as [Trait(Category.AcceptanceType, Category.BVT)] they will be run post PR merge in a separate job.

stankovski added a commit that referenced this pull request Oct 19, 2015
@stankovski
Merge pull request #1116 from yoavrubin/dev
4d2f8d7 
Updating dynamic data masking to use the RuleState property
@stankovski stankovski merged commit 4d2f8d7 into Azure:dev Oct 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoavrubin @azurecla @stankovski